2018-01-17 - SLPG Meeting
Date & Time
20:00 UTC Wednesday 17th January 2018
Teleconference Details
To join the meeting please go to https://snomed.zoom.us/j/471420169.
Further information can be found at SLPG meeting information
Goals
Review proposed Query language examples
Attendees
Chair: @Former user (Deleted)
Project Group: @Ed Cheetham, @Rob Hausam, @Former user (Deleted)
Apologies
Agenda and Meeting Notes
Description | Owner | Notes |
|---|---|---|
Welcome and apologies | @Former user (Deleted) |
|
Recent comments | @Former user (Deleted) | Michael: "How can I write an ECL expression to match attribute names - for example, list all the attribute names that are used by << 404684003 |Clinical finding|. Daniel: "Query language and collation" When specifying the lexical search type for term matching there is a need to specify the collation used, and to specify the default collation for the language in which the terms are to be matched are represented. Examples based on mysql collation behavior: "AAO" matches "ÅÄÖ" in utf8_generic_ci and utf8_unicode_ci (and utf8_german2_ci) but not in utf8_swedish_ci collation. "Aåa" matches "aåa" in utf8_generic_ci and utf8_swedish_ci but not in utf8_bin collation (i.e. case insesitive vs. sensitive, sometimes you need case sensitivity when searching...). Similar behavior can be implemented e.g. by java.text.Collator in java or by the collection.find() or cursor.collation() method in MongoDB. |
Query Language | @Former user (Deleted) |
|
Confirm next meeting date/time | @Former user (Deleted) | Next meeting to be held at 20:00 UTC on Wednesday 31st January 2018 |
Comments
That last one doesn't surprise me since there are only two in the International Edition.
@Dion McMurtrie or @Matt Cordell might be able to provide some input from the AU perspective
Just on the first point, we conduct all our QA against snapshot also. (Can't change the past).
The only QA we (AU) do, (and I suspect SI's RVF) on Delta and Full, is a comparison to previous release. (Though the "first full" should be tested too).
As for modules... Sigh. @Michael is aware of some difficulties we've encountered this month... I suspect the RVF (like the AU tests) validates an edition. I haven't checked what the RVF has. Most of our tests are fairly agnostic of moduleId. We've got an (incomplete) set of specific QA that checks moduleId assignment. But have discovered issues associated with the MDRS.. I'll be creating a topic for #TRAG to discuss.
The qa rules for SE, DK, BE were also included, not just the international release.
Dear All,
I have reached out to Andrew A and he directed me to the QA rules on github: https://github.com/IHTSDO/release-validation-framework/tree/master/importer/src/main/resources/scripts
The subfodlers contain SQL files which implement some of the quality checks. I ran some grep queries to identify quieries in which moduleId and relationships are referred to. My findings were:
As we discussed last time, queries are applied on a snapshot and, thus, release-type QA is out of scope (??)
(Some/many) QA rules detect conditions that cannot be described in the current query langage, like all sourceIds are not null, all sourceId are in the concept table, no active additional relationships, etc. Since the query language is a bolt-on on ECL, it requires a certain level of correctness.
All current QA queries refering to moduleId relate to a single module, no queries across modules
I'm on a late train home, and I haven't eaten, so I might or might not make it tonight.